Skip to content

fix: crash with InvalidAuthBlockingTokenError #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 16, 2023
Merged

fix: crash with InvalidAuthBlockingTokenError #145

merged 10 commits into from
Oct 16, 2023

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Oct 9, 2023 •
edited
Loading

Fixes #133
Fixes #144

@exaby73 exaby73 linked an issue Oct 9, 2023 that may be closed by this pull request
Crash, when is trying to sign up with Apple or Google providers #133
Closed
@exaby73 exaby73 mentioned this pull request Oct 9, 2023
Closed
@exaby73 exaby73 linked an issue Oct 9, 2023 that may be closed by this pull request
First time login fails - KeyError: 'last_sign_in_time' #144
Closed
russellwheatley
russellwheatley approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley changed the title fix: crash with InvalidAuthBlockingTokenError (wrong audience) fix: crash with InvalidAuthBlockingTokenError Oct 9, 2023
@exaby73 exaby73 requested a review from taeold October 9, 2023 12:11
@exaby73
Copy link
Contributor Author

exaby73 commented Oct 10, 2023

Lint error will be fixed on merge of #147

@exaby73 exaby73 force-pushed the feat/fix_identify_before_user_create_InvalidAuthBlockingTokenError branch from 8a9c376 to 4d93b43 Compare October 10, 2023 14:36
@taeold
Copy link
Collaborator

taeold commented Oct 10, 2023

Before I merge - can you fix the linter issues?

@exaby73
Merge remote-tracking branch 'origin/feat/fix_identify_before_user_cr…
4946c4f 
…eate_InvalidAuthBlockingTokenError' into feat/fix_identify_before_user_create_InvalidAuthBlockingTokenError
@exaby73
fix: line too long lint
424fb08
@exaby73
fix: type checks and formatting
e759b1e
@exaby73
Merge remote-tracking branch 'origin' into feat/fix_identify_before_u…
fdb06b2 
…ser_create_InvalidAuthBlockingTokenError
@exaby73 exaby73 mentioned this pull request Oct 11, 2023
Closed
@EmilioNicolas
Copy link

Hi! When can we expect this issue merged and deployed? thanks!!

@taeold taeold merged commit d06ccb6 into main Oct 16, 2023
@taeold taeold deleted the feat/fix_identify_before_user_create_InvalidAuthBlockingTokenError branch October 16, 2023 21:55
@EmilioNicolas
Copy link

Hi! Is it already in PRO? should we wait to other release?

@exaby73
Copy link
Contributor Author

exaby73 commented Oct 24, 2023

This should be fixed in 0.1.2, which hasn't been released yet, but will be soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salakar Salakar Salakar approved these changes

@taeold taeold taeold approved these changes

@russellwheatley russellwheatley russellwheatley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@exaby73 @taeold @EmilioNicolas @Salakar @russellwheatley